Optimize code structure to improve code readability and maintainability.

2024-05-06 20:46:28 +08:00
parent 91344e99ab
commit c492f86356
6 changed files with 72 additions and 69 deletions
@@ -1,60 +1,63 @@
 def get_grade(student_client, output_type="none"):
    # 获取成绩信息
-    grade_data = student_client.get_grade("").get("data", {})
+    grade_data = student_client.get_grade().get("data", {})
    grade = grade_data.get("courses", [])

-    # 遍历 grade 中的每个字典，将 title 中的中文括号替换为英文括号
-    for course_data_grade in grade:
-        course_data_grade["title"] = (
-            course_data_grade["title"].replace("（", "(").replace("）", ")")
+    # 成绩不为空时
+    if grade:
+        # 遍历 grade 中的每个字典，将 title 中的中文括号替换为英文括号
+        for course_data_grade in grade:
+            course_data_grade["title"] = (
+                course_data_grade["title"].replace("（", "(").replace("）", ")")
+            )
+
+        # 按照提交时间降序排序
+        sorted_grade = sorted(grade, key=lambda x: x["submission_time"], reverse=True)
+
+        # 学分总和
+        total_credit = sum(float(course["credit"]) for course in grade)
+
+        # 学分绩点总和
+        total_xfjd = sum(float(course["xfjd"]) for course in grade)
+
+        # (百分制成绩*学分)的总和
+        sum_of_percentage_grades_multiplied_by_credits = sum(
+            float(course["percentage_grades"]) * float(course["credit"])
+            for course in grade
        )

-    # 按照提交时间降序排序
-    sorted_grade = sorted(grade, key=lambda x: x["submission_time"], reverse=True)
+        # GPA计算 (学分*绩点)的总和/学分总和
+        gpa = "{:.2f}".format(total_xfjd / total_credit)

-    # 学分总和
-    total_credit = sum(float(course["credit"]) for course in grade)
-
-    # 学分绩点总和
-    total_xfjd = sum(float(course["xfjd"]) for course in grade)
-
-    # (百分制成绩*学分)的总和
-    sum_of_percentage_grades_multiplied_by_credits = sum(
-        float(course["percentage_grades"]) * float(course["credit"]) for course in grade
-    )
-
-    # GPA计算 (学分*绩点)的总和/学分总和
-    gpa = "{:.2f}".format(total_xfjd / total_credit)
-
-    # 百分制GPA计算 (百分制成绩*学分)的总和/学分总和
-    percentage_gpa = "{:.2f}".format(
-        sum_of_percentage_grades_multiplied_by_credits / total_credit
-    )
-
-    # 初始化输出成绩信息字符串
-    integrated_grade_info = "成绩信息："
-
-    # 遍历前8条成绩信息
-    for _, course in enumerate(sorted_grade[:8]):
-        # 整合成绩信息
-        integrated_grade_info += (
-            f"\n"
-            f"教学班ID：{course['class_id']}\n"
-            f"课程名称：{course['title']}\n"
-            f"任课教师：{course['teacher']}\n"
-            f"成绩：{course['grade']}\n"
-            f"提交时间：{course['submission_time']}\n"
-            f"提交人姓名：{course['name_of_submitter']}\n"
-            f"------"
+        # 百分制GPA计算 (百分制成绩*学分)的总和/学分总和
+        percentage_gpa = "{:.2f}".format(
+            sum_of_percentage_grades_multiplied_by_credits / total_credit
        )

-    if output_type == "grade":
-        return grade
-    elif output_type == "gpa":
-        return gpa
-    elif output_type == "percentage_gpa":
-        return percentage_gpa
-    elif output_type == "integrated_grade_info":
-        return integrated_grade_info
-    else:
-        return "获取成绩：参数缺失"
+        # 初始化输出成绩信息字符串
+        integrated_grade_info = "成绩信息："
+
+        # 遍历前8条成绩信息
+        for _, course in enumerate(sorted_grade[:8]):
+            # 整合成绩信息
+            integrated_grade_info += (
+                f"\n"
+                f"教学班ID：{course['class_id']}\n"
+                f"课程名称：{course['title']}\n"
+                f"任课教师：{course['teacher']}\n"
+                f"成绩：{course['grade']}\n"
+                f"提交时间：{course['submission_time']}\n"
+                f"提交人姓名：{course['name_of_submitter']}\n"
+                f"------"
+            )
+
+        if output_type == "grade":
+            return grade
+        elif output_type == "gpa":
+            return gpa
+        elif output_type == "percentage_gpa":
+            return percentage_gpa
+        elif output_type == "integrated_grade_info":
+            return integrated_grade_info
+        else:
+            return "获取成绩：参数缺失"